netdev - Re: [PATCH] cxgb3: No need to wake queue in xmit handler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <op.u1vm9wbjduofyu@cayman.asicdesigners.com>
Date:	Thu, 15 Oct 2009 22:09:22 -0700
From:	"Divy Le Ray" <divy@...lsio.com>
To:	"Krishna Kumar" <krkumar2@...ibm.com>, davem@...emloft.net
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] cxgb3: No need to wake queue in xmit handler

On Wed, 14 Oct 2009 22:54:19 -0700, Krishna Kumar <krkumar2@...ibm.com>  
wrote:

> The xmit handler doesn't need to wake the queue after stopping
> it temporarily (some other drivers are doing the same).
>
> Patch on net-next-2.6, multiple netperf sessions tested.
>
> Signed-off-by: Krishna Kumar <krkumar2@...ibm.com>
Acked-by: Divy Le Ray <divy@...lsio.com>
> ---
>
>  drivers/net/cxgb3/sge.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff -ruNp org/drivers/net/cxgb3/sge.c new/drivers/net/cxgb3/sge.c
> --- org/drivers/net/cxgb3/sge.c	2009-09-07 10:09:03.000000000 +0530
> +++ new/drivers/net/cxgb3/sge.c	2009-09-07 10:11:11.000000000 +0530
> @@ -1260,7 +1260,7 @@ netdev_tx_t t3_eth_xmit(struct sk_buff *
>  		if (should_restart_tx(q) &&
>  		    test_and_clear_bit(TXQ_ETH, &qs->txq_stopped)) {
>  			q->restarts++;
> -			netif_tx_wake_queue(txq);
> +			netif_tx_start_queue(txq);
>  		}
>  	}
>


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html