netdev - Re: [net-next PATCH 0/3] qlge: Size RX buffers based on MTU.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20091016.175142.52482970.davem@davemloft.net>
Date:	Fri, 16 Oct 2009 17:51:42 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	ron.mercer@...gic.com
Cc:	netdev@...r.kernel.org
Subject: Re: [net-next PATCH 0/3] qlge: Size RX buffers based on MTU.

From: Ron Mercer <ron.mercer@...gic.com>
Date: Fri, 16 Oct 2009 13:15:33 -0700

> These patches are interdependent.

No, Ron, they are absolutely not.

Apply the first patch, and that breaks the build because
you've removed LARGE_BUFFER_SIZE but it's still referenced
in qlge_main.c, and there are tons of other breakages too.

Don't send me garbage like this and then claim it's a set
of independent patches.  A trivial build test would have
shown otherwise, but you obviously didn't do that.

This is completely rediculious:

  CC [M]  drivers/net/qlge/qlge_main.o
drivers/net/qlge/qlge_main.c: In function ‘ql_update_lbq’:
drivers/net/qlge/qlge_main.c:1081: error: ‘union <anonymous>’ has no member named ‘lbq_page’
drivers/net/qlge/qlge_main.c:1085: error: ‘union <anonymous>’ has no member named ‘lbq_page’
drivers/net/qlge/qlge_main.c:1086: error: ‘union <anonymous>’ has no member named ‘lbq_page’
drivers/net/qlge/qlge_main.c:1093: error: ‘union <anonymous>’ has no member named ‘lbq_page’
drivers/net/qlge/qlge_main.c:1098: error: ‘union <anonymous>’ has no member named ‘lbq_page’
drivers/net/qlge/qlge_main.c:1099: error: ‘union <anonymous>’ has no member named ‘lbq_page’
drivers/net/qlge/qlge_main.c: In function ‘ql_build_rx_skb’:
drivers/net/qlge/qlge_main.c:1491: error: ‘union <anonymous>’ has no member named ‘lbq_page’
drivers/net/qlge/qlge_main.c:1496: error: ‘union <anonymous>’ has no member named ‘lbq_page’
drivers/net/qlge/qlge_main.c:1518: error: ‘union <anonymous>’ has no member named ‘lbq_page’
drivers/net/qlge/qlge_main.c:1524: error: ‘union <anonymous>’ has no member named ‘lbq_page’
drivers/net/qlge/qlge_main.c:1584: error: ‘union <anonymous>’ has no member named ‘lbq_page’
drivers/net/qlge/qlge_main.c:1590: error: ‘union <anonymous>’ has no member named ‘lbq_page’
drivers/net/qlge/qlge_main.c: In function ‘ql_free_lbq_buffers’:
drivers/net/qlge/qlge_main.c:2313: error: ‘union <anonymous>’ has no member named ‘lbq_page’
drivers/net/qlge/qlge_main.c:2319: error: ‘union <anonymous>’ has no member named ‘lbq_page’
drivers/net/qlge/qlge_main.c:2320: error: ‘union <anonymous>’ has no member named ‘lbq_page’
drivers/net/qlge/qlge_main.c: In function ‘ql_configure_rings’:
drivers/net/qlge/qlge_main.c:3546: error: ‘LARGE_BUFFER_SIZE’ undeclared (first use in this function)
drivers/net/qlge/qlge_main.c:3546: error: (Each undeclared identifier is reported only once
drivers/net/qlge/qlge_main.c:3546: error: for each function it appears in.)
make[3]: *** [drivers/net/qlge/qlge_main.o] Error 1
make[2]: *** [drivers/net/qlge] Error 2
make[1]: *** [drivers/net] Error 2
make: *** [drivers] Error 2
make: *** Waiting for unfinished jobs....