netdev - Re: [PATCH 2/8] bitmap: Introduce bitmap_set, bitmap_clear, bitmap_find_next_zero

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20091017224028V.fujita.tomonori@lab.ntt.co.jp>
Date:	Sat, 17 Oct 2009 22:43:02 +0900
From:	FUJITA Tomonori <fujita.tomonori@....ntt.co.jp>
To:	akinobu.mita@...il.com
Cc:	akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
	fujita.tomonori@....ntt.co.jp, davem@...emloft.net,
	sparclinux@...r.kernel.org, benh@...nel.crashing.org,
	paulus@...ba.org, linuxppc-dev@...abs.org, tglx@...utronix.de,
	mingo@...hat.com, hpa@...or.com, x86@...nel.org, gregkh@...e.de,
	LW@...O-electronics.de, linux-usb@...r.kernel.org,
	rolandd@...co.com, yevgenyp@...lanox.co.il, netdev@...r.kernel.org,
	tony.luck@...el.com, fenghua.yu@...el.com,
	linux-ia64@...r.kernel.org, linux-altix@....com
Subject: Re: [PATCH 2/8] bitmap: Introduce bitmap_set, bitmap_clear,
	bitmap_find_next_zero_area

On Tue, 13 Oct 2009 18:10:17 +0900
Akinobu Mita <akinobu.mita@...il.com> wrote:

> My user space testing exposed off-by-one error find_next_zero_area
> in iommu-helper. Some zero area cannot be found by this bug.
> 
> Subject: [PATCH] Fix off-by-one error in find_next_zero_area
> 
> Signed-off-by: Akinobu Mita <akinobu.mita@...il.com>
> ---
>  lib/iommu-helper.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/lib/iommu-helper.c b/lib/iommu-helper.c
> index 75dbda0..afc58bc 100644
> --- a/lib/iommu-helper.c
> +++ b/lib/iommu-helper.c
> @@ -19,7 +19,7 @@ again:
>  	index = (index + align_mask) & ~align_mask;
>  
>  	end = index + nr;
> -	if (end >= size)
> +	if (end > size)

I think that this is intentional; the last byte of the limit doesn't
work.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html