netdev - Re: [PATCH] can: provide library functions for skb allocation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4ADB6279.3000403@grandegger.com>
Date:	Sun, 18 Oct 2009 20:46:17 +0200
From:	Wolfgang Grandegger <wg@...ndegger.com>
To:	David Miller <davem@...emloft.net>
CC:	netdev@...r.kernel.org, socketcan-core@...ts.berlios.de,
	haas@...-wuensche.com, anantgole@...com, mkl@...gutronix.de
Subject: Re: [PATCH] can: provide library functions for skb allocation

David Miller wrote:
> From: Wolfgang Grandegger <wg@...ndegger.com>
> Date: Thu, 15 Oct 2009 11:22:18 +0200
> 
>> +	skb->protocol = __constant_htons(ETH_P_CAN);
> 
> Please don't use __constant_htonX() for runtime invocatios.
> It's only for situation which must be compile time evaluations
> such as case statements and static initializations.
> 
> GCC can figure out that's it's constant if you just use
> plan htonX().

OK, I just dent out v2 of this patch.

Wolfgang.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html