netdev - Re: [PATCH] genetlink: Optimize and one bug fix in genl_generate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20091017.235810.19115879.davem@davemloft.net>
Date:	Sat, 17 Oct 2009 23:58:10 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	krkumar2@...ibm.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] genetlink: Optimize and one bug fix in
 genl_generate_id()

From: Krishna Kumar <krkumar2@...ibm.com>
Date: Thu, 15 Oct 2009 11:25:07 +0530

> From: Krishna Kumar <krkumar2@...ibm.com>
> 
> 1. GENL_MIN_ID is a valid id -> no need to start at
>    GENL_MIN_ID + 1.
> 2. Avoid going through the ids two times: If we start at
>    GENL_MIN_ID+1 (*or bigger*) and all ids are over!, the
>    code iterates through the list twice (*or lesser*).
> 3. Simplify code - no need to start at idx=0 which gets
>    reset to GENL_MIN_ID.
> 
> Patch on net-next-2.6. Reboot test shows that first id
> passed to genl_register_family was 16, next two were
> GENL_ID_GENERATE and genl_generate_id returned 17 & 18
> (user level testing of same code shows expected values
> across entire range of MIN/MAX).
> 
> Signed-off-by: Krishna Kumar <krkumar2@...ibm.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html