netdev - Re: [PATCH] myri10ge: improve port type reporting in ethtool output

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1255939929.3916.13.camel@localhost>
Date:	Mon, 19 Oct 2009 09:12:09 +0100
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	Brice Goglin <brice@...i.com>
Cc:	"David S. Miller" <davem@...emloft.net>,
	Linux Network Development list <netdev@...r.kernel.org>
Subject: Re: [PATCH] myri10ge: improve port type reporting in ethtool output

On Mon, 2009-10-19 at 07:35 +0200, Brice Goglin wrote:
> Improve the reporting of the port type in ethtool,
> update for new boards.
> 
> Signed-off-by: Brice Goglin <brice@...i.com>
> 
> --- a/drivers/net/myri10ge/myri10ge.c
> +++ b/drivers/net/myri10ge/myri10ge.c
> @@ -75,7 +75,7 @@
>  #include "myri10ge_mcp.h"
>  #include "myri10ge_mcp_gen_header.h"
>  
> -#define MYRI10GE_VERSION_STR "1.5.0-1.432"
> +#define MYRI10GE_VERSION_STR "1.5.1-1.450"
>  
>  MODULE_DESCRIPTION("Myricom 10G driver (10GbE)");
>  MODULE_AUTHOR("Maintainer: help@...i.com");
> @@ -1601,6 +1601,8 @@ myri10ge_get_settings(struct net_device *netdev,
> struct ethtool_cmd *cmd)
>      cmd->autoneg = AUTONEG_DISABLE;
>      cmd->speed = SPEED_10000;
>      cmd->duplex = DUPLEX_FULL;
> +    cmd->supported = SUPPORTED_10000baseT_Full;
> +    cmd->advertising = ADVERTISED_10000baseT_Full;
[...]

Lying about link modes is not an improvement.

Ben.

-- 
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html