netdev - Re: [PATCH]bnx2x: remove duplication of the BCM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1256197367.4101.22.camel@lb-tlvb-eilong>
Date:	Thu, 22 Oct 2009 09:42:47 +0200
From:	"Eilon Greenstein" <eilong@...adcom.com>
To:	"kirjanov@...il.com" <kirjanov@...il.com>
cc:	"davem@...emloft.net" <davem@...emloft.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH]bnx2x: remove duplication of the BCM_VLAN macro

On Wed, 2009-10-21 at 13:38 -0700, Denis Kirjanov 
> File bnx2.c already contains condition of the macro inclusion.
> So we can remove this.

It is true that BCM_VLAN is defined in bnx2.c, however it is not defined
in bnx2x_*.c files. The definition in bnx2x.h is needed for the bnx2x.ko
module.

Please do not remove it.

Thanks,
Eilon

> Signed-off-by: Denis Kirjanov <kirjanov@...il.com>
> ---
> 
> diff --git a/drivers/net/bnx2x.h b/drivers/net/bnx2x.h
> index bbf8422..4b99fd2 100644
> --- a/drivers/net/bnx2x.h
> +++ b/drivers/net/bnx2x.h
> @@ -20,10 +20,6 @@
>   * (you will need to reboot afterwards) */
>  /* #define BNX2X_STOP_ON_ERROR */
>  
> -#if defined(CONFIG_VLAN_8021Q) || defined(CONFIG_VLAN_8021Q_MODULE)
> -#define BCM_VLAN			1
> -#endif
> -
>  
>  #define BNX2X_MULTI_QUEUE
>  



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html