netdev - Re: [PATCH] net: use WARN() for the WARN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20091022.213812.83606333.davem@davemloft.net>
Date:	Thu, 22 Oct 2009 21:38:12 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	arjan@...radead.org
Cc:	herbert@...dor.apana.org.au, netdev@...r.kernel.org
Subject: Re: [PATCH] net: use WARN() for the WARN_ON in commit b6b39e8f3fbbb

From: Arjan van de Ven <arjan@...radead.org>
Date: Thu, 22 Oct 2009 20:35:12 -0700

> Commit b6b39e8f3fbbb (tcp: Try to catch MSG_PEEK bug) added a printk()
> to the WARN_ON() that's in tcp.c. This patch changes this combination
> to WARN(); the advantage of WARN() is that the printk message shows up
> inside the message, so that kerneloops.org will collect the message.
> 
> In addition, this gets rid of an extra if() statement.
> 
> Signed-off-by: Arjan van de Ven <arjan@...ux.intel.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html