lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 23 Oct 2009 16:27:09 +0200 From: Tilman Schmidt <tilman@...p.cc> To: Johannes Berg <johannes@...solutions.net> CC: Jarek Poplawski <jarkao2@...il.com>, David Miller <davem@...emloft.net>, hidave.darkstar@...il.com, linux-kernel@...r.kernel.org, tglx@...utronix.de, linux-wireless@...r.kernel.org, linux-ppp@...r.kernel.org, netdev@...r.kernel.org, paulus@...ba.org, isdn4linux <isdn4linux@...tserv.isdn4linux.de>, i4ldeveloper <i4ldeveloper@...tserv.isdn4linux.de>, Karsten Keil <isdn@...ux-pingi.de> Subject: Re: NOHZ: local_softirq_pending 08 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Johannes Berg schrieb: > On Fri, 2009-10-23 at 01:37 +0200, Tilman Schmidt wrote: > >> --- a/drivers/isdn/i4l/isdn_ppp.c >> +++ b/drivers/isdn/i4l/isdn_ppp.c >> @@ -1174,7 +1174,10 @@ isdn_ppp_push_higher(isdn_net_dev * net_dev, isdn_net_local * lp, struct sk_buff >> #endif /* CONFIG_IPPP_FILTER */ >> skb->dev = dev; >> skb_reset_mac_header(skb); >> - netif_rx(skb); >> + if (in_interrupt()) >> + netif_rx(skb); >> + else >> + netif_rx_ni(skb); > > So you've verified that the entire i4l stack can cope with being called > twice on the same CPU, from different contexts? What makes you think so? Better yet, what do you propose? Thanks, Tilman - -- Tilman Schmidt E-Mail: tilman@...p.cc Bonn, Germany Diese Nachricht besteht zu 100% aus wiederverwerteten Bits. Ungeöffnet mindestens haltbar bis: (siehe Rückseite) -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.4 (MingW32) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFK4b09Q3+did9BuFsRAqBvAKCbRI0iXQEyK3ztxkGHcqpbcceqbACgkagX JF7nYd152ihp2uemIs/cB54= =YOin -----END PGP SIGNATURE----- -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists