netdev - udp: break from the lookup when hitting the maximum score value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <200910231936.16022.lgrijincu@ixiacom.com>
Date:	Fri, 23 Oct 2009 19:36:15 +0300
From:	Lucian Adrian Grijincu <lgrijincu@...acom.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	opurdila@...acom.com, netdev@...r.kernel.org
Subject: udp: break from the lookup when hitting the maximum score value

Before udp hashes were converted to rcu in
	udp: introduce struct udp_table and multiple spinlocks
	645ca708f936b2fbeb79e52d7823e3eb2c0905f8
we stopped searching in list upon hitting the maximum score value (which is 
9).

This got removed in the conversion to rcu.
I'm not sure whether this was intentional or it just slipped by.

As far as I understand it this does not interfere with the lockless rcu: there 
is another score check the result will have to pass and if it doesn't have a 
score of 9 (which will be the value of badness) we'll just restart the lookup.

Even if the node was deleted from the chain and reclaimed at a later time, if 
at the second score test we have value 9 again, we can still return with this 
result.

Am I missing something?

-- 
Lucian

View attachment "score-9.patch" of type "text/plain" (644 bytes)