netdev - dev_flags definitions in broadcom.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20091028212545.GA9055@xw6200.broadcom.net>
Date:	Wed, 28 Oct 2009 14:25:45 -0700
From:	"Matt Carlson" <mcarlson@...adcom.com>
To:	"Nate Case" <ncase@...-inc.com>
cc:	"Maciej W. Rozycki" <macro@...ux-mips.org>,
	"Jeff Garzik" <jgarzik@...hat.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: dev_flags definitions in broadcom.c

Nate, On May 17, 2008 you submitted a patch titled
"PHYLIB: Add 1000Base-X support for Broadcom bcm5482".  In that patch
you defined several dev_flags definitions for the broadcom module.  I
only see the PHY_BCM_FLAGS_MODE_1000BX being used in the code though.  I
quickly scanned through the phy_connect calls in drivers/net and didn't
see any caller using this preprocessor definition or an equivalent
hardcoded constant.  Perhaps I missed something though.  Can you tell me
where these flags are set?

My interest in this is several-fold.  First, I'd like to move the
definitions to include/linux/brcmphy.h so that the same preprocessor
definitons can be used at both ends.  But more important than that, I'd
like to get a handle on how many of these definitions are actually used
and how many are just placeholders.  With only 32-bits to use, the flags
might become a precious resource.  I have plans for a few of these bits
myself, and I'd like reviewers to take note of how they are used.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html