netdev - RE: [Pv-drivers] [PATCH] vmxnet3: remove duplicate #include

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8B1F619C9F5F454E81D90D3C161698D7017DFAA30F@EXCH-MBX-3.vmware.com>
Date:	Thu, 29 Oct 2009 06:35:35 -0700
From:	Bhavesh Davda <bhavesh@...are.com>
To:	David Miller <davem@...emloft.net>,
	Shreyas Bhatewara <sbhatewara@...are.com>
CC:	"pv-drivers@...are.com" <pv-drivers@...are.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"weiyi.huang@...il.com" <weiyi.huang@...il.com>
Subject: RE: [Pv-drivers] [PATCH] vmxnet3: remove duplicate #include

> From: David Miller <davem@...emloft.net>
> Date: Wed, 28 Oct 2009 22:29:01 -0700 (PDT)
> 
> > From: Shreyas Bhatewara <sbhatewara@...are.com>
> > Date: Wed, 28 Oct 2009 09:30:40 -0700 (PDT)
> >
> >>
> >> Remove duplicate headerfile includes from vmxnet3_int.h
> >>
> >> Signed-off-by: Shreyas Bhatewara <sbhatewara@...are.com>
> >> Signed-off-by: Huang Weiyi <weiyi.huang@...il.com>
> >> Signed-off-by: Bhavesh Davda <davda@...are.com>
> >
> > Applied.
> 
> Guys, I'd like to remove the X86 Kconfig requirement for this
> driver.  There really isn't any x86 specific code in the
> driver, it uses only standard PCI and networking APIs to function.
> 
> I know the virtual hardware won't be seen on other platforms,
> but allowing the driver to get build tested on non-x86 platforms
> helps me a lot.  I do all of my build verifications on sparc64
> for example.

The driver shares in-memory data structures with the device emulation in the hypervisor, so in the VMware case since they are both on x86, we don't need any cpu_to_le32 or le32_to_cpu's when accessing them. But for correctness, if you were to compile the vmxnet3 driver for a big-endian architecture like sparc64, we will need to sprinkle those around all accesses to the shared data structures.

In other words, don't just trivially remove the X86 Kconfig requirement for this driver.

Thanks

- Bhavesh
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html