[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Thu, 29 Oct 2009 20:09:05 -0700
From: Stephen Hemminger <shemminger@...ux-foundation.org>
To: Brandon Philips <bphilips@...e.de>
Cc: netdev@...r.kernel.org
Subject: Re: [PATCH] sky2: set carrier off in probe
On Thu, 29 Oct 2009 16:58:07 -0700
Brandon Philips <bphilips@...e.de> wrote:
> Before bringing up a sky2 interface up ethtool reports
> "Link detected: yes". Do as ixgbe does and netif_carrier_off() on
> probe().
>
> Signed-off-by: Brandon Philips <bphilips@...e.de>
>
> ---
> drivers/net/sky2.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> Index: linux-2.6/drivers/net/sky2.c
> ===================================================================
> --- linux-2.6.orig/drivers/net/sky2.c
> +++ linux-2.6/drivers/net/sky2.c
> @@ -4538,6 +4538,8 @@ static int __devinit sky2_probe(struct p
> goto err_out_free_netdev;
> }
>
> + netif_carrier_off(dev);
> +
> netif_napi_add(dev, &hw->napi, sky2_poll, NAPI_WEIGHT);
>
> err = request_irq(pdev->irq, sky2_intr,
IMHO carrier is meaningless until device is up? What software
cares?
--
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists