netdev - Re: [PATCH 4/6] vlan: Optimize multiple unregistration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20091029.234312.06466996.davem@davemloft.net>
Date:	Thu, 29 Oct 2009 23:43:12 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	kaber@...sh.net, netdev@...r.kernel.org
Subject: Re: [PATCH 4/6] vlan: Optimize multiple unregistration

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Fri, 30 Oct 2009 07:30:43 +0100

> Patrick McHardy a écrit :
>> Eric Dumazet wrote:
>>> Patrick McHardy a écrit :
>>>
>>>> Indeed, but unregister_vlan_dev() destroys the group once the
>>>> count has reached zero, so we must not access it after that.
>>> Well, I hoped call_rcu() callback doesnt fire and kfree(grp) until we exited
>>> from unregister_vlan_dev_alls(), with RTNL locked...
>> 
>> The RTNL is a mutex, so it shouldn't prevent call_rcu from firing.
> 
> Oops this is totally right of course, so your patch is actually a bug fix :)
> 
> Acked-by: Eric Dumazet <eric.dumazet@...il.com>

I've applied Patrick's patch, thanks everyone.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html