netdev - RE: [PATCH v3 4/7] fsl_pq_mdio: Add Suport for etsec2.0 devices.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9F4C7D19E8361D4C94921B95BE08B81B9503CA@zin33exm22.fsl.freescale.net>
Date:	Fri, 30 Oct 2009 12:52:29 +0530
From:	"Kumar Gopalpet-B05799" <B05799@...escale.com>
To:	<netdev@...r.kernel.org>
Cc:	"Fleming Andy-AFLEMING" <afleming@...escale.com>,
	"David Miller" <davem@...emloft.net>
Subject: RE: [PATCH v3 4/7] fsl_pq_mdio: Add Suport for etsec2.0 devices.

 

>Did you try the bundle I posted yesterday which failed?  This 
>one is identical, you didn't change anything.
>
>This is getting rediculious.
>
>Try again, and when you do take the patches from patchwork at:
>
>	http://patchwork.ozlabs.org/project/netdev/list/
>
>and you try to apply them to net-next-2.6 using git (_not_ 
>'patch', 'patch' is way too lenient about fuzz and line 
>offsets) so that you can see what's happening.
>
>I'm completely ignoring your patch postings until you sort this out.

1. The patch failure is due to the absence of following commit in
net-next-2.6 tree.
	
	commit e72701acbe0b35e52d3f04d442837c06b4e64f1c
	Author: Anton Vorontsov <avorontsov@...mvista.com>
	Date:   Wed Oct 14 14:54:52 2009 -0700

	    net: Fix OF platform drivers coldplug/hotplug when compiled
as modules

	    Some OF platform drivers are missing module device tables,
so they won't
	    load automatically on boot. This patch fixes the issue by
adding proper
	    MODULE_DEVICE_TABLE() macros to the drivers.

	Signed-off-by: Anton Vorontsov <avorontsov@...mvista.com>
      Signed-off-by: David S. Miller <davem@...emloft.net>

2. The git clone DOES NOT show the changes affected by the above patch
3. If we take a log of the affected file(fsl_pq_mdio.c), then it DOES
show the commit/changes 
   (Gitweb:
http://git.kernel.org/?p=linux/kernel/git/davem/net-next-2.6.git;a=histo
ry;f=drivers/net/fsl_pq_mdio.c;h=6ac4648669728421b934d32646ffbb626128387
6;hb=HEAD)
4. If we take the log of the tree, the same commit is NOT visible. 
  (Gitweb:
http://git.kernel.org/?p=linux/kernel/git/davem/net-next-2.6.git;a=log)
5. If we take a Snapshot of the tree, the changes to the file are
present. (in the tarball)

To sum up, the Clone and Tree log DOES NOT show the changes.
The Snapshot and file log DOES show it.

We have tried it on multiple machine/tree clones here.
Is there some problem with the Git tree itself?

>
>You cannot have line offsets or fuzz when you send patches 
>that are to be applied by GIT, and that is the problem with patch #4:
>
>davem@...set:~/src/GIT/net-next-2.6$ patch -p1 <diff patching 
>file drivers/net/fsl_pq_mdio.c Hunk #6 succeeded at 436 with fuzz 1.
>patching file drivers/net/fsl_pq_mdio.h
>
>GIT does not allow line fuzz, you must make absolutely 
>pristine patches, and therefore if you are testing your 
>submission with just 'patch' that absolutely will not work.
No we are using git-am.
We did try this on multiple clones of the net-next-2.6 tree.
>
>Thanks.
>--
>To unsubscribe from this list: send the line "unsubscribe 
>netdev" in the body of a message to majordomo@...r.kernel.org 
>More majordomo info at  http://vger.kernel.org/majordomo-info.html
>



--

Thanks
Sandeep
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html