netdev - Re: [PATCH 5/6] bond: Implement a basic set of rtnl link ops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4AEAB2F1.5070200@trash.net>
Date:	Fri, 30 Oct 2009 10:33:37 +0100
From:	Patrick McHardy <kaber@...sh.net>
To:	"Eric W. Biederman" <ebiederm@...ssion.com>
CC:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
	Jay Vosburgh <fubar@...ibm.com>,
	"Eric W. Biederman" <ebiederm@...stanetworks.com>
Subject: Re: [PATCH 5/6] bond: Implement a basic set of rtnl link ops

Eric W. Biederman wrote:
> Patrick McHardy <kaber@...sh.net> writes:
> 
>> Eric W. Biederman wrote:
>>> +static struct rtnl_link_ops bond_link_ops __read_mostly = {
>>> +	.kind		= "bond",
>>> +	.setup		= bond_setup,
>>> +	.validate	= bond_validate,
>>> +};
>> One more thing - you need to initialize .priv_size here so
>> the devices created through rtnl_link have enough private
>> room allocated.
> 
> Wow and the code works when I test it without that ouch!
> 
> As for rtnl_link_register it always succeeds so let's just
> remove the return code and call it good.

You need unroll anyways for the other failure conditions, so
why not simply add an err1/2 and be safe for future changes?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html