netdev - Re: [PATCH 0/6] Bonding simplifications and netns support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <m1ljisid8n.fsf@fess.ebiederm.org>
Date:	Fri, 30 Oct 2009 18:06:00 -0700
From:	ebiederm@...ssion.com (Eric W. Biederman)
To:	Jay Vosburgh <fubar@...ibm.com>
Cc:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [PATCH 0/6] Bonding simplifications and netns support

Jay Vosburgh <fubar@...ibm.com> writes:

> 	No, to both questions.  Also, if I back out the 7 bonding
> patches, the same insmod / rmmod does not panic.  
>
> 	I just set it up and did it again.  Fresh boot of the system
> (which doesn't load bonding); "insmod drivers/net/bonding/bonding.ko;
> rmmod bonding" and blammo.
>
> 	A little bisect action reveals that the problem first appears
> after applying the fifth patch (below).  Does a basic insmod / rmmod
> cycle work ok for you?  I'm specifying no options to bonding.

It works here.  The only issue I found was that veth wasn't quite
working.   I am wondering if there was some version of the tree
where rtnl_link_unregister is broken and you applied the patches to that.

I tested the net-next tree with my patches at the top:

There are some other differences like I am running a 64bit kernel but
I don't expect that would make a difference in practice.

Eric

commit 6639104bd826e0b1388c69a6b7564fffc636c8a8
Author: Eric W. Biederman <ebiederm@...ssion.com>
Date:   Thu Oct 29 23:58:54 2009 +0000

    bond: Get the rtnl_link_ops support correct

    - Don't call rtnl_link_unregister if rtnl_link_register fails
    - Set .priv_size so we aren't stomping on uninitialized memory
      when we use netdev_priv, on bond devices created with
      ip link add type bond.

    Signed-off-by: Eric W. Biederman <ebiederm@...stanetworks.com>
    Signed-off-by: David S. Miller <davem@...emloft.net>

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html