netdev - Re: [PATCH] r8169: partial support and phy init for the 8168d

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091102190618.GM4236@decadent.org.uk>
Date:	Mon, 2 Nov 2009 19:06:18 +0000
From:	Ben Hutchings <ben@...adent.org.uk>
To:	David Miller <davem@...emloft.net>
Cc:	romieu@...zoreil.com, netdev@...r.kernel.org,
	edward_hsu@...ltek.com.tw
Subject: Re: [PATCH] r8169: partial support and phy init for the 8168d

On Sun, Nov 01, 2009 at 10:46:45PM -0800, David Miller wrote:
> From: Ben Hutchings <ben@...adent.org.uk>
> Date: Sun, 01 Nov 2009 16:24:43 +0000
> 
> > I believe this is patching machine code in the PHY.  And we do not have
> > source for that code, so it cannot possibly be distributed under GPL.
> 
> You don't know if it's machine code or some data values that
> are used to control the PHY's execution.

No, I don't know that this is machine code.  But you are setting up
a false opposition: 'data values that are used to control the PHY's
execution' certainly include the machine code that it executes.

> In fact I would really be surprised if they had some cpu interpeting
> code in the 8168d PHY.

Your knowledge of PHYs may be outdated.  1000BASE-T has to be done
with a mixture of analog and digital signal processing, since analog
alone would be too power-hungry.  While autonegotiation and power
management could be hardwired it's less risky to put in a micro-
controller and finalise the firmware after the silicon... or even
after release, as seems to have happened here.

> You did do some research about that before making such accusations
> right? :-)

I began with 'I believe'.  It's not an accusation.

Ben.

-- 
Ben Hutchings
Sturgeon's Law: Ninety percent of everything is crap.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html