netdev - Re: [PATCH] usbnet: Do not implement ethtool get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200911030141.27905.david-b@pacbell.net>
Date:	Tue, 3 Nov 2009 02:41:27 -0700
From:	David Brownell <david-b@...bell.net>
To:	David Miller <davem@...emloft.net>
Cc:	ben@...adent.org.uk, greg@...ah.com, jacmet@...site.dk,
	steve.glendinning@...c.com, netdev@...r.kernel.org
Subject: Re: [PATCH] usbnet: Do not implement ethtool get_link() if link state is unknown

On Tuesday 03 November 2009, David Miller wrote:
> > Having two tables for this is needlessly ugly.
> 
> Yes, it's really cruddy how the USB network driver tries to share
> so much state amongst such very different devices :-)

That framework just grew ... started out as one driver,
nearly ten years back (yow!!), then generalized.  Folk
seemed to appreciate not reinventing some stuff.  ;)

If it had started out with this many devices, it might have
looked more like a library.  Sharing code implies sharing
at least some state representations; the balance could might
be worth shifting by now.


> All kidding aside, I think the alternative is for the USB network
> driver to call ethtool_op_get_link() if it cannot determine the
> link state in hardware.

There's usbnet_get_link() which does just that.  But
there may be some ancient debris confusing things.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html