netdev - RE: Subject: [PATCH 1/6] bna: Brocade 10Gb Ethernet device driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1257294718.2892.23.camel@Joe-Laptop.home>
Date:	Tue, 03 Nov 2009 16:31:58 -0800
From:	Joe Perches <joe@...ches.com>
To:	Rasesh Mody <rmody@...cade.com>
Cc:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	Adapter Linux Open SRC Team 
	<adapter_linux_open_src_team@...cade.COM>,
	Greg Kroah-Hartman <gregkh@...e.de>
Subject: RE: Subject: [PATCH 1/6] bna: Brocade 10Gb Ethernet device driver

On Tue, 2009-11-03 at 10:24 -0800, Rasesh Mody wrote:
> Joe,
> Thanks for your input. We are in the process addressing the comments that we are getting.

Hi Rasesh.

Thanks for bringing this out to netdev.

I think that with a few hours of cleanup, the code
would be more linux style conforming.  But right now,
it looks a bit odd with too many indirections.

> Can you please give examples or elaborate your comment? It would be really helpful.

OS dependent includes?  Most of them are senseless.

All of bfa_os_inc.h should go elsewhere or be dropped.
All of bna_os should go elsewhere or be dropped.

drop all bna_os_ prefixes

drop all bfa_os_ntohs, etc:

sed -r -i -e 's/\bbfa_os_(nh)to(nh)(sl)\b/\1to\2\3/g' *

Redefine true/false? why?

sed -r -i -e 's/\bbfa_boolean_t\b/bool/g' *
sed -r -i -e 's/\bBFA_TRUE\b/true/g' *
sed -r -i -e 's/\bBFA_FALSE\b/false/g' *

Don't suffix struct names with _s

sed -r -i -e 's/\bstruct\b\s+(\w+)\s+(\w+)_s/struct \1 \2/g' *

bfa_panic -> bfa_os_panic -> nothing

a laundry list like that...

I think it should go into staging for a few weeks, and then
it would be ready to be integrated into a mainline release.

cheers,  Joe 

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html