lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 04 Nov 2009 23:22:14 -0800 (PST) From: David Miller <davem@...emloft.net> To: gilad@...efidence.com Cc: Valdis.Kletnieks@...edu, netdev@...r.kernel.org, ori@...sleep.com, linux-kernel@...r.kernel.org, akpm@...ux-foundation.org Subject: Re: [PATCH testing] Do not call IPv4 specific func in tcp_check_req From: Gilad Ben-Yossef <gilad@...efidence.com> Date: Wed, 4 Nov 2009 18:40:54 +0200 > Calling IPv4 specific inet_csk_route_req in tcp_check_req > is a bad idea and crashes machine on IPv6 connections, as reported > by Valdis Kletnieks > > Also, all we are really interested in is the timestamp > option in the header, so calling tcp_parse_options() > with the "estab" set to false flag is an overkill as > it tries to parse half a dozen other TCP options. > > We know whether timestamp should be enabled or not > using data from request_sock. > > Signed-off-by: Gilad Ben-Yossef <gilad@...efidence.com> Applied, thanks. I assume that your other patch which attempted to fix this isn't necessary. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists