netdev - Re: [PATCH 19/25] mlx4: Randomizing mac addresses for slaves

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <adabpjhc6az.fsf@roland-alpha.cisco.com>
Date:	Thu, 05 Nov 2009 07:58:12 -0800
From:	Roland Dreier <rdreier@...co.com>
To:	"Liran Liss" <liranl@...lanox.co.il>
Cc:	"Or Gerlitz" <or.gerlitz@...il.com>,
	"Yevgeny Petrilin" <yevgenyp@...lanox.co.il>,
	<linux-rdma@...r.kernel.org>, <netdev@...r.kernel.org>,
	"Tziporet Koren" <tziporet@...lanox.co.il>
Subject: Re: [PATCH 19/25] mlx4: Randomizing mac addresses for slaves


 > This approach seems to be common practice now (e.g., drivers/net/igb/igb_main.c:1332).
 > In any case, the user can change the randomized mac.

igb uses the full output of random_ether_addr().  I'd be fine with
that.  However setting the OUI means you only get 24 bits of randomness
which makes a collision a lot more likely.

 - R.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html