netdev - Re: [PATCH net-next2.6] ipv6: avoid dev_hold()/dev_put() in rawv6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4AF4536E.7090803@hp.com>
Date:	Fri, 06 Nov 2009 11:48:46 -0500
From:	Brian Haley <brian.haley@...com>
To:	Eric Dumazet <eric.dumazet@...il.com>
CC:	"David S. Miller" <davem@...emloft.net>,
	Linux Netdev List <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next2.6] ipv6: avoid dev_hold()/dev_put() in rawv6_bind()

Eric Dumazet wrote: 
> @@ -257,6 +257,7 @@ static int rawv6_bind(struct sock *sk, struct sockaddr *uaddr, int addr_len)
>  	if (sk->sk_state != TCP_CLOSE)
>  		goto out;
>  
> +	rcu_read_unlock();
>  	/* Check if the address belongs to the host. */
>  	if (addr_type != IPV6_ADDR_ANY) {
>  		struct net_device *dev = NULL;

This was supposed to be rcu_read_lock(), right?

-Brian
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html