lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <4AF464FF.10609@gmail.com> Date: Fri, 06 Nov 2009 19:03:43 +0100 From: Eric Dumazet <eric.dumazet@...il.com> To: Lucian Adrian Grijincu <lgrijincu@...acom.com> CC: David Miller <davem@...emloft.net>, netdev@...r.kernel.org, opurdila@...acom.com Subject: Re: [PATCH net-next-2.6 take2] ipv6: udp: Optimise multicast reception Lucian Adrian Grijincu a écrit : > În data de Vin 06 Noi 2009 19:54:55 Eric Dumazet a scris: >> We should atomic_inc(&sk->sk_drops) in the case skb_clone() >> could not provide a copy, and eventually increment UDP_MIB_RCVBUFERRORS & >> UDP_MIB_INERRORS SNMP counters > > Shouldn't this be also done if udp_queue_rcv_skb() returned a failure code (a > positive number) instead of silently droping? > Nope, this is correctly done in __udp_queue_rcv_skb() & sock_queue_rcv_skb() Only multicast is lazy in this area. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists