netdev - Re: [PATCH net-next-2.6] ip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20091105.210827.137296827.davem@davemloft.net>
Date:	Thu, 05 Nov 2009 21:08:27 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	joe@...ches.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next-2.6] ip_frag:

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Wed, 04 Nov 2009 23:11:49 +0100

> [PATCH net-next-2.6] ip_frag: dont touch device refcount
> 
> When sending fragmentation expiration ICMP V4/V6 messages,
> we can avoid touching device refcount, thanks to RCU
> 
> Signed-off-by: Eric Dumazet <eric.dumazet@...il.com>

Applied to net-next-2.6

Although I was worried a little bit initially about the
ipv4 case, as we're assigning the device pointer to
"skb->dev" and I thought it might be troublesome for
that reference to escape.

But that seems ok, because icmp_send() doesn't do anything interesting
with it's 'skb_in' arg other than look at the attached route, the
packet contents, and things like that.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html