netdev - Re: [RFC] netlink: add socket destruction notification

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20091105.210806.40981707.davem@davemloft.net>
Date:	Thu, 05 Nov 2009 21:08:06 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	johannes@...solutions.net
Cc:	netdev@...r.kernel.org, j@...fi, tgraf@...g.ch
Subject: Re: [RFC] netlink: add socket destruction notification

From: Johannes Berg <johannes@...solutions.net>
Date: Fri, 02 Oct 2009 10:44:08 +0200

> When we want to keep track of resources associated with applications, we
> need to know when an app is going away. Add a notification function to
> netlink that tells us that, and also hook it up to generic netlink so
> generic netlink can notify the families. Due to the way generic netlink
> works though, we need to notify all families and they have to sort out
> whatever resources some commands associated with the socket themselves.
> 
> Signed-off-by: Johannes Berg <johannes@...solutions.net>

No fundamental objections.

However, as a followup, netlink_kernel_create() is becomming
function_that_takes_too_many_arguments().

At this point it's better to just pass two arguments, the network
namespace pointer, and a pointer to a "const struct netlink_kern_info"
that holds the rest of the parameters.

Could you make that change too?

Thanks!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html