netdev - Re: [PATCH RFC] gianfar: Do not call skb recycling with disabled IRQs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20091108.010848.116517157.davem@davemloft.net>
Date:	Sun, 08 Nov 2009 01:08:48 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	avorontsov@...mvista.com
Cc:	jdl@....com, linuxppc-dev@...abs.org, jason.wessel@...driver.com,
	afleming@...escale.com, netdev@...r.kernel.org,
	buytenh@...tstofly.org, shemminger@...tta.com
Subject: Re: [PATCH RFC] gianfar: Do not call skb recycling with disabled
 IRQs

From: Anton Vorontsov <avorontsov@...mvista.com>
Date: Thu, 5 Nov 2009 19:57:38 +0300

> But that basically means that with skb recycling we can't safely
> use KGDBoE, though we can add something like this:

Please stop adding special logic only to your driver to handle these
things.

Either it's a non-issue, or it's going to potentially be an issue for
everyone using skb_recycle_check() in a NAPI driver, right?

So why not add the "in_interrupt()" or whatever check to
skb_recycle_check() and if the context is unsuitable return false (0)
ok?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html