netdev - Re: [PATCH] can: should not use __dev_get_by

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20091108.003425.21973000.davem@davemloft.net>
Date:	Sun, 08 Nov 2009 00:34:25 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	socketcan@...tkopp.net
Cc:	eric.dumazet@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH] can: should not use __dev_get_by_index() without locks

From: Oliver Hartkopp <socketcan@...tkopp.net>
Date: Fri, 06 Nov 2009 12:04:16 +0100

> Eric Dumazet wrote:
>> [PATCH] can: should not use __dev_get_by_index() without locks
>> 
>> bcm_proc_getifname() is called with RTNL and dev_base_lock
>> not held. It calls __dev_get_by_index() without locks, and
>> this is illegal (might crash)
>> 
>> Close the race by holding dev_base_lock and copying dev->name
>> in the protected section.
>> 
>> Signed-off-by: Eric Dumazet <eric.dumazet@...il.com>
 ...
> Signed-off-by: Oliver Hartkopp <oliver@...tkopp.net>

Applied, thanks everyone.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html