netdev - Re: [PATCH] check the return value of ndo_select

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20091109.011311.203110058.davem@davemloft.net>
Date:	Mon, 09 Nov 2009 01:13:11 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	xiaosuo@...il.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] check the return value of ndo_select_queue()

From: Changli Gao <xiaosuo@...il.com>
Date: Mon, 9 Nov 2009 16:44:05 +0800

> On Mon, Nov 9, 2009 at 3:26 PM, David Miller <davem@...emloft.net> wrote:
>> From: Changli Gao <xiaosuo@...il.com>
>> Date: Mon, 09 Nov 2009 15:17:17 +0800
>>
>>> check the return value of ndo_select_queue()
>>>
>>> Check the return value of ndo_select_queue(). If the value isn't smaller
>>> than the real_num_tx_queues, print a warning message, and reset it to zero.
>>>
>>> Signed-off-by: Changli Gao <xiaosuo@...il.com>
>>
>> Make it a WARN() so that it ends up in kerneloops.org
>>
> Like this?
>                         WARN(1, "%s selects TX queue %d, "
>                              "but real number of TX queues is %d\n",
>                              dev->name, queue_index, dev->real_num_tx_queues);

Yes, something like that.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html