netdev - Re: [PATCH] check the return value of ndo_select

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4AF7E8C2.90707@gmail.com>
Date:	Mon, 09 Nov 2009 11:02:42 +0100
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	xiaosuo@...il.com
CC:	"David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [PATCH] check the return value of ndo_select_queue()

Eric Dumazet a écrit :
> 
> Yes, but this is a _very_ unlikely condition (a bug IMHO), so you could use :
> 
> if (unlikely(queue_index >= dev->real_num_tx_queues)) {
> 	...
> }
> 
> (This unlikely() clause is implied in WARN... macros)
> 

Also, you want to trigger this message only once, or ratelimit it at least

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html