netdev - Re: [PATCH] e1000e: Fix usage under kexec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87tyx2k9hy.fsf@basil.nowhere.org>
Date:	Tue, 10 Nov 2009 10:35:37 +0100
From:	Andi Kleen <andi@...stfloor.org>
To:	Sven Anders <sven@...uras.de>
Cc:	netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH] e1000e: Fix usage under kexec

Sven Anders <sven@...uras.de> writes:
>
> We get the following error:
>   e1000e: probe of 0000:02:00.0 failed with error -2
>
> We cannot unload the driver of the first kernel, because it's
> compiled in statically.
>
> It's caused by the PHY, because it's already initialized by the
> first driver and therefore does not respond correctly. The driver
> assumes the PHY to be in 'reset' state, which is done by the BIOS.
>
> We fixed it by adding a
>
> +       /* Reset PHY before initializing it. Allows re-init after kexec. */
> +       if (!e1000_check_reset_block(hw))
> +         e1000_phy_hw_reset(hw);

The problem of resetting PHYs in the driver init path is that it tends
to lose link-state, and if the link takes some time to re-negotiate
you can significantly slow down the "total time to network access"
at boot.

Perhaps you could only reset when the message above would trigger
and try again?

-Andi
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html