netdev - Re: [PATCH] RDMA/addr: Use appropriate locking with for_each

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 11 Nov 2009 10:25:48 -0800
From:	Roland Dreier <rdreier@...co.com>
To:	"Sean Hefty" <sean.hefty@...el.com>
Cc:	"'Eric Dumazet'" <eric.dumazet@...il.com>,
	"David S. Miller" <davem@...emloft.net>,
	"Linux Netdev List" <netdev@...r.kernel.org>,
	"Roland Dreier" <rolandd@...co.com>,
	"Hal Rosenstock" <hal.rosenstock@...il.com>,
	"linux-rdma" <linux-rdma@...r.kernel.org>
Subject: Re: [PATCH] RDMA/addr: Use appropriate locking with for_each_netdev()


 > >for_each_netdev() should be used with RTNL or dev_base_lock held,
 > >or risk a crash.
 > >
 > >Signed-off-by: Eric Dumazet <eric.dumazet@...il.com>
 > 
 > Thanks - I'm working on a patch set in this area.  Roland, I can merge Eric's
 > changes into that patch set if it makes things easier.

Would it be possible for you to take Eric's patch as the first in your
set (keeping his From: of course) and base your fixes on top of that?
That seems the cleanest thing to me.

Thanks,
  Roland
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html