netdev - Re: [PATCH 13/13] pcmcia: rework the irq_req

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 11 Nov 2009 21:46:03 +0100
From:	Marcel Holtmann <marcel@...tmann.org>
To:	Dominik Brodowski <linux@...inikbrodowski.net>
Cc:	linux-pcmcia@...ts.infradead.org, netdev@...r.kernel.org,
	linux-bluetooth@...r.kernel.org, linux-ide@...r.kernel.org,
	linux-wireless@...r.kernel.org, linux-scsi@...r.kernel.org,
	alsa-devel@...a-project.org, Jaroslav Kysela <perex@...ex.cz>,
	Jiri Kosina <jkosina@...e.cz>,
	Karsten Keil <isdn@...ux-pingi.de>
Subject: Re: [PATCH 13/13] pcmcia: rework the irq_req_t typedef

Hi Dominik,

> Most of the irq_req_t typedef'd struct can be re-worked quite
> easily:
> 
> (1) IRQInfo2 was unused in any case, so drop it.
> 
> (2) IRQInfo1 was used write-only, so drop it.
> 
> (3) Instance (private data to be passed to the IRQ handler):
> 	Most PCMCIA drivers using pcmcia_request_irq() to actually
> 	register an IRQ handler set the "dev_id" to the same pointer
> 	as the "priv" pointer in struct pcmcia_device. Modify the two
> 	exceptions (ipwireless, ibmtr_cs) to also work this waym and
> 	set the IRQ handler's "dev_id" to p_dev->priv unconditionally.
> 
> (4) Handler is to be of type irq_handler_t.
> 
> (5) Handler != NULL already tells whether an IRQ handler is present.
> 	Therefore, we do not need the IRQ_HANDLER_PRESENT flag in
> 	irq_req_t.Attributes.
> 
> CC: netdev@...r.kernel.org
> CC: linux-bluetooth@...r.kernel.org
> CC: linux-ide@...r.kernel.org
> CC: linux-wireless@...r.kernel.org
> CC: linux-scsi@...r.kernel.org
> CC: alsa-devel@...a-project.org
> CC: Jaroslav Kysela <perex@...ex.cz>
> CC: Jiri Kosina <jkosina@...e.cz>
> CC: Karsten Keil <isdn@...ux-pingi.de>
> Signed-off-by: Dominik Brodowski <linux@...inikbrodowski.net>
> ---
>  drivers/ata/pata_pcmcia.c                        |    1 -
>  drivers/bluetooth/bluecard_cs.c                  |    4 +---
>  drivers/bluetooth/bt3c_cs.c                      |    4 +---
>  drivers/bluetooth/btuart_cs.c                    |    4 +---
>  drivers/bluetooth/dtl1_cs.c                      |    4 +---

for the Bluetooth parts:

Acked-by: Marcel Holtmann <marcel@...tmann.org>

Regards

Marcel


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html