lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <alpine.DEB.2.00.0911111339100.9485@bicker> Date: Wed, 11 Nov 2009 14:03:54 +0200 (SAST) From: Dan Carpenter <error27@...il.com> To: netdev@...r.kernel.org cc: davem@...emloft.net Subject: [patch] missing dev_put() on error path in vif_add() The other error paths in front of this one have a dev_put() but this one got missed. Found by smatch static checker. regards, dan carpenter Signed-off-by: Dan Carpenter <error27@...il.com> --- orig/net/ipv4/ipmr.c 2009-11-11 13:34:20.000000000 +0200 +++ devel/net/ipv4/ipmr.c 2009-11-11 13:34:59.000000000 +0200 @@ -483,8 +483,10 @@ return -EINVAL; } - if ((in_dev = __in_dev_get_rtnl(dev)) == NULL) + if ((in_dev = __in_dev_get_rtnl(dev)) == NULL) { + dev_put(dev); return -EADDRNOTAVAIL; + } IPV4_DEVCONF(in_dev->cnf, MC_FORWARDING)++; ip_rt_multicast_event(in_dev); -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists