[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20091112231620.0b56c0b0@opy.nosense.org>
Date: Thu, 12 Nov 2009 23:16:20 +1030
From: Mark Smith <lk-netdev@...netdev.nosense.org>
To: David Miller <davem@...emloft.net>
Cc: opurdila@...acom.com, shemminger@...tta.com, netdev@...r.kernel.org
Subject: Re: [PATCH] [next-next-2.6] net: configurable device name hash
On Wed, 11 Nov 2009 18:36:26 -0800 (PST)
David Miller <davem@...emloft.net> wrote:
> From: Octavian Purdila <opurdila@...acom.com>
> Date: Wed, 11 Nov 2009 23:47:41 +0200
>
> > We could use a similar function that will work in the per namespace
> > initialization context, but this might upset net namespace folks
> > since we will get a large hash for every namespace.
>
> Use kzalloc(), that's sufficient for a 64K or so hash table which is
> way more than you ever will need.
>
> Use the GFP_* flags that will silently (ie. without a log message)
> fail, and divide by two until you successfully allocate the table if
> you're worried about memory fragmentation at allocation time.
>
> This is so straightforward, I can't believe we're talking so much
> about how to implement this, it's a 15 minute hack :-)
Yes, but sadly, sometimes there is too much history(!) to be able to be
fully aware of it. "suck-it-and-see" type patches are possibly a
quicker way to find out what people are thinking right now!
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists