netdev - Re: [PATCH net-2.6] Revert "net: Support inclusion of <linux/socket.h> before <sys/socket.h>"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 11 Nov 2009 18:51:24 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	ben@...adent.org.uk
Cc:	netdev@...r.kernel.org, 538372@...s.debian.org
Subject: Re: [PATCH net-2.6] Revert "net: Support inclusion of
 <linux/socket.h> before <sys/socket.h>"

From: Ben Hutchings <ben@...adent.org.uk>
Date: Thu, 12 Nov 2009 02:00:05 +0000

> This reverts commit 9c501935a3cdcf6b1d35aaee3aa11c7a7051a305.  That
> commit caused <linux/rtnetlink.h> to require that <sys/socket.h> is
> included first, breaking autoconf tests for <linux/rtnetlink.h> and
> presumably some real programs too.
> 
> Signed-off-by: Ben Hutchings <ben@...adent.org.uk>

I'm not reverting this Ben.  The dependency those programs and
autoconf tests have is _dubious_ at best.

It means they were depending upon the libc5 checks passing, that's
rediculious and not something we should cater to.

If you really want it to work that linux/rtnetlink.h is included first
before sys/socket.h in userland, fix that specifically instead.  But
I believe such a dependency is reasonable and the userspace bits need
fixing.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html