lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <4AFC6ECD.5030009@gmail.com> Date: Thu, 12 Nov 2009 21:23:41 +0100 From: Eric Dumazet <eric.dumazet@...il.com> To: Tom Herbert <therbert@...gle.com> CC: David Miller <davem@...emloft.net>, netdev@...r.kernel.org Subject: Re: [PATCH 1/2] rps: core implementation Tom Herbert a écrit : > Third version of RPS. > > Signed-off-by: Tom Herbert <therbert@...gle.com> > --- > include/linux/interrupt.h | 1 + > include/linux/netdevice.h | 18 ++++ > include/linux/skbuff.h | 2 + > net/core/dev.c | 227 ++++++++++++++++++++++++++++++++++++++------- > net/core/net-sysfs.c | 135 +++++++++++++++++++++++++++ > 5 files changed, 348 insertions(+), 35 deletions(-) > @@ -2696,21 +2842,24 @@ static int process_backlog(struct napi_struct *napi, int quota) int work = 0; struct softnet_data *queue = &__get_cpu_var(softnet_data); unsigned long start_time = jiffies; + unsigned long flags; napi->weight = weight_p; do { struct sk_buff *skb; <<HERE>> local_irq_disable(); + spin_lock_irqsave(&queue->input_pkt_queue.lock, flags); skb = __skb_dequeue(&queue->input_pkt_queue); if (!skb) { __napi_complete(napi); - local_irq_enable(); + spin_unlock_irqrestore(&queue->input_pkt_queue.lock, + flags); break; } - local_irq_enable(); + spin_unlock_irqrestore(&queue->input_pkt_queue.lock, flags); - netif_receive_skb(skb); + __netif_receive_skb(skb); } while (++work < quota && jiffies == start_time); return work; Not sure you still want the local_irq_disable() before spin_lock_irqsave(&queue->input_pkt_queue.lock, flags); ? -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists