netdev - Re: [PATCH] s2io: fixing a ethtool test that is broken

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20091113.193600.215645997.davem@davemloft.net>
Date:	Fri, 13 Nov 2009 19:36:00 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	Sivakumar.Subramani@...erion.com
Cc:	leitao@...ux.vnet.ibm.com, netdev@...r.kernel.org,
	Sreenivasa.Honnur@...erion.com, Ramkrishna.Vepa@...erion.com
Subject: Re: [PATCH] s2io: fixing a ethtool test that is broken

From: "Sivakumar Subramani" <Sivakumar.Subramani@...erion.com>
Date: Thu, 12 Nov 2009 13:59:53 -0500

> [Siva] Reviewed the patch. Please accept it.
> 
> Acked-by: Sivakumar Subramani <sivakumar.subramani@...erion.com>

Please use reasonable mechanisms to reply to patches when you review
them.  Something in your mail client software or elsewhere has messed
with the Message-Id and other elements of the email headers, and
therefore the threading of messages so that patchwork and other tools
can attach your reply to the patch posting itself simply do not work.

This makes more work for me and I am not going to go searching for
your replies by hand.

So you should fix this because otherwise your review reply ACKs
will get lost.

Also you have this very non-standard way to attributing your content
by adding these "[Name]" tags.  Please don't do that, it is
non-standard and therefore most people don't understand it at all.

The normal email reply quoting mechanisms of your email client will
let us know exactly what parts are written by you, and what parts are
said by other people in quoted text.

Thank you.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html