| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20091116182145.GB15157@caffeine.csclub.uwaterloo.ca> Date: Mon, 16 Nov 2009 13:21:45 -0500 From: lsorense@...lub.uwaterloo.ca (Lennart Sorensen) To: David Miller <davem@...emloft.net> Cc: lsorense@...lub.uwaterloo.ca, netdev@...r.kernel.org Subject: Re: Those gpio-mdio patches... On Fri, Nov 13, 2009 at 01:59:08PM -0800, David Miller wrote: > Please don't fix the issue that way. If the routine is returning a > true or false value, make it return a 'bool' instead of an 'int'. > That way we don't have to "accept something other than 0 and 1" Hmm. Well I just tried to fix what was already there. gpio-lib does NOT return 0 or 1, it returns 0 or 1 shifted by the gpio position in a gpio register, but soemthing has to convert that to a boolean value. Making it return a bool doesn't change the fact it needs the '!!' applied to make it a bool. I can look at changing the mdio-gpio to using bool instead of integer where necesary. -- Len Sorensen -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists