netdev - Re: sparse vs. skbuff.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1258399627.32159.41.camel@johannes.local>
Date:	Mon, 16 Nov 2009 20:27:07 +0100
From:	Johannes Berg <johannes@...solutions.net>
To:	netdev <netdev@...r.kernel.org>
Cc:	Eric Dumazet <eric.dumazet@...il.com>,
	Vegard Nossum <vegard.nossum@...il.com>
Subject: Re: sparse vs. skbuff.h

On Mon, 2009-11-16 at 20:21 +0100, Johannes Berg wrote:
> commit 14d18a81b5171d4433e41129619c75748b4f4d26
> Author: Eric Dumazet <eric.dumazet@...il.com>
> Date:   Thu Oct 29 00:10:37 2009 +0000
> 
>     net: fix kmemcheck annotations
> 
> 
> broke sparse endian checks on everything that includes skbuff.h because
> the first and only (because it's an error) thing sparse now reports is
> this:
> 
> include/linux/skbuff.h:357:41: error: invalid bitfield specifier for type restricted __be16.

Simply changing from
	__be16 protocol:16;
to
	__be16 protocol;

but leaving it inside the kmemcheck annotation seems to do the right
thing. Except of course that kmemcheck will not properly check it now.
Maybe those annotations should simply be made to have no impact on
struct padding instead?

johannes

Download attachment "signature.asc" of type "application/pgp-signature" (802 bytes)