netdev - Re: [PATCH] TI Davinci EMAC : Fix Console Hang when bringing the interface down

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20091115.221759.210122830.davem@davemloft.net>
Date:	Sun, 15 Nov 2009 22:17:59 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	srk@...com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] TI Davinci EMAC : Fix Console Hang when bringing the
 interface down

From: Sriramakrishnan <srk@...com>
Date: Thu, 12 Nov 2009 17:25:42 +0530

> In the NAPI poll function(emac_poll), check for netif_running()
> is unnecassary. In addition to associated runtime overhead, it
> also results in a continuous softirq loop when the interface is
> brought down under heavy traffic(tested wit Traffic Generator).
> Once the interface is disabled, the poll function always returns
> zero(with the check for netif_running) and napi_complete() would
> never get called resulting in softirq loop.
> 
> Signed-off-by: Sriramakrishnan <srk@...com>
> Acked-by: Chaithrika U S <chaithrika@...com>

Applied to net-2.6
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html