netdev - Re: [PATCH 2/2] act_mirred: optimization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1258365990.3251.33.camel@bigi>
Date:	Mon, 16 Nov 2009 05:06:30 -0500
From:	jamal <hadi@...erus.ca>
To:	Changli Gao <xiaosuo@...il.com>
Cc:	"David S. Miller" <davem@...emloft.net>,
	Stephen Hemminger <shemminger@...tta.com>,
	netdev@...r.kernel.org
Subject: Re: [PATCH 2/2] act_mirred: optimization

On Mon, 2009-11-16 at 17:53 +0800, Changli Gao wrote:

Just one small comment; sorry, i missed this the first time:

> +		if (dev == NULL)
>  			return -EINVAL;
>  		pc = tcf_hash_create(parm->index, est, a, sizeof(*m), bind,
>  				     &mirred_idx_gen, &mirred_hash_info);
>  		if (IS_ERR(pc))
> -		    return PTR_ERR(pc);
> +			return PTR_ERR(pc);

One indent too many? 

cheers,
jamal

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html