netdev - Re: [PATCH 2/2] act_mirred: optimization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20091116.025859.78494103.davem@davemloft.net>
Date:	Mon, 16 Nov 2009 02:58:59 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	xiaosuo@...il.com
Cc:	hadi@...erus.ca, shemminger@...tta.com, netdev@...r.kernel.org
Subject: Re: [PATCH 2/2] act_mirred: optimization

From: David Miller <davem@...emloft.net>
Date: Mon, 16 Nov 2009 02:48:39 -0800 (PST)

> From: Changli Gao <xiaosuo@...il.com>
> Date: Mon, 16 Nov 2009 17:53:29 +0800
> 
>> act_mirred: optimization.
>> 
>> move checking if eaction is valid in tcf_mirred_init()
>> 
>> Signed-off-by: Changli Gao <xiaosuo@...il.com>
>> Signed-off-by: Jamal Hadi Salim <hadi@...erus.ca>
> 
> Also applied, thank you.

Nevermind, you're NOT TESTING the patches you are posting:

net/sched/act_mirred.c: In function ‘tcf_mirred’:
net/sched/act_mirred.c:168: error: label ‘out’ used but not defined
net/sched/act_mirred.c:158: warning: unused variable ‘err’
net/sched/act_mirred.c:158: warning: unused variable ‘retval’
make[2]: *** [net/sched/act_mirred.o] Error 1
make[1]: *** [net/sched] Error 2
make[1]: *** Waiting for unfinished jobs....

I'm thus reverting both changes.

Don't submit changes which are untested, it wastes my time.