netdev - Re: [PATCH net] net: Fix the rollback test in dev_change

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 16 Nov 2009 03:31:12 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	jarkao2@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH net] net: Fix the rollback test in dev_change_name()

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Mon, 16 Nov 2009 12:08:22 +0100

> David Miller a écrit :
>> From: Jarek Poplawski <jarkao2@...il.com>
>> Date: Mon, 16 Nov 2009 09:30:24 +0000
>> 
>>> From: Eric Dumazet <eric.dumazet@...il.com>
>>>
>>> net: Fix the rollback test in dev_change_name()
>>>
>>> In dev_change_name() an err variable is used for storing the original
>>> call_netdevice_notifiers() errno (negative) and testing for a rollback
>>> error later, but the test for non-zero is wrong, because the err might
>>> have positive value as well - from dev_alloc_name(). It means the
>>> rollback for a netdevice with a number > 0 will never happen. (The err
>>> test is reordered btw. to make it more readable.)
>>>
>>> Signed-off-by: Jarek Poplawski <jarkao2@...il.com>
>>> Cc: Eric Dumazet <eric.dumazet@...il.com>
 ...
>> Eric please give your signoff and I'll put this where it needs
>> to go.
 ...
> Signed-off-by: Eric Dumazet <eric.dumazet@...il.com>

Applied to net-2.6 and queued for -stable, thanks everyone!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html