netdev - Re: [PATCH] vlan: Fix register_vlan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 17 Nov 2009 06:45:21 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	netdev@...r.kernel.org, kaber@...sh.net
Subject: Re: [PATCH] vlan: Fix register_vlan_dev() error path

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Tue, 17 Nov 2009 15:41:26 +0100

> David Miller a écrit :
> 
>> Eric, please make allocation failure cause the vlan_setup()
>> to fail and propagate -EFAULT back to the caller.
> 
> Sure ! (You meant -ENOMEM probably...)

Indeed.

> [PATCH] vlan: Fix register_vlan_dev() error path
> 
> In case register_netdevice() returns an error, and a new vlan_group was
> allocated and inserted in vlan_group_hash[] we call vlan_group_free() without
> deleting group from hash table. Future lookups can give infinite loops or crashes.
> 
> We must delete the vlan_group using RCU safe procedure.
> 
> Signed-off-by: Eric Dumazet <eric.dumazet@...il.com>

Good catch, applied to net-2.6 and queued up for -stable.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html