netdev - Re: [PATCH 2/3] TI Davinci EMAC : add platform specific interrupt enable/disable logic.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87pr7fbh5p.fsf@deeprootsystems.com>
Date:	Wed, 18 Nov 2009 14:29:54 -0800
From:	Kevin Hilman <khilman@...prootsystems.com>
To:	Troy Kisky <troy.kisky@...ndarydevices.com>
Cc:	Sriramakrishnan <srk@...com>, netdev@...r.kernel.org,
	davinci-linux-open-source@...ux.davincidsp.com
Subject: Re: [PATCH 2/3] TI Davinci EMAC : add platform specific interrupt enable/disable logic.

Troy Kisky <troy.kisky@...ndarydevices.com> writes:

> Sriramakrishnan wrote:
>> On certain SOCs, the EMAC controller is interfaced with a wrapper logic
>> for handling interrupts. This  patch implements a platform
>> specific hook to cater to platforms that require custom interrupt
>> handling logic
>> 
>> Signed-off-by: Sriramakrishnan <srk@...com>
>> Acked-by: Chaithrika U S <chaithrika@...com>
>> ---
>>  drivers/net/davinci_emac.c   |   11 +++++++++++
>>  include/linux/davinci_emac.h |    2 ++
>>  2 files changed, 13 insertions(+), 0 deletions(-)
>> 
>> diff --git a/drivers/net/davinci_emac.c b/drivers/net/davinci_emac.c
>> index 6aec8f5..81931f8 100644
>> --- a/drivers/net/davinci_emac.c
>> +++ b/drivers/net/davinci_emac.c
>> @@ -487,6 +487,9 @@ struct emac_priv {
>>  	struct mii_bus *mii_bus;
>>  	struct phy_device *phydev;
>>  	spinlock_t lock;
>> +	/*platform specific members*/
>> +	void (*wrapper_int_enable) (void);
>> +	void (*wrapper_int_disable) (void);
>
> Would platform_int_enable be more appropriate then wrapper_int_enable ?
>

Or just int_enable.  As it's being used through a private pointer,
it's clear that it's a wrapper.

Kevin
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html