netdev - Re: [net-next-2.6 PATCH v2] allow access to sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091118164126.GF325@e-circ.dyndns.org>
Date:	Wed, 18 Nov 2009 17:41:26 +0100
From:	Kurt Van Dijck <kurt.van.dijck@....be>
To:	David Miller <davem@...emloft.net>
Cc:	shemminger@...tta.com, netdev@...r.kernel.org
Subject: Re: [net-next-2.6 PATCH v2] allow access to sysfs_groups member

This patch allows adding sysfs attribute groups during netdevice registration.
The idea is that before the register_netdev call, several calls to
netdev_sysfs_add_group can be done. These attributes are accessible (by
udev) during the uevent.

Signed-off-by: Kurt Van Dijck <kurt.van.dijck@....be>
Acked-by: Stephen Hemminger <shemminger@...tta.com>
---
 include/linux/netdevice.h |    2 ++
 net/core/net-sysfs.c      |   29 ++++++++++++++++++++++++-----
 2 files changed, 26 insertions(+), 5 deletions(-)

diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
index 8380009..ebfc789 100644
--- a/include/linux/netdevice.h
+++ b/include/linux/netdevice.h
@@ -1115,6 +1115,8 @@ extern int                dev_open(struct net_device *dev);
 extern int             dev_close(struct net_device *dev);
 extern void            dev_disable_lro(struct net_device *dev);
 extern int             dev_queue_xmit(struct sk_buff *skb);
+extern int             netdev_sysfs_add_group(struct net_device *net,
+                               const struct attribute_group *grp);
 extern int             register_netdevice(struct net_device *dev);
 extern void            unregister_netdevice(struct net_device *dev);
 extern void            free_netdev(struct net_device *dev);
diff --git a/net/core/net-sysfs.c b/net/core/net-sysfs.c
index 753c420..6451e9a 100644
--- a/net/core/net-sysfs.c
+++ b/net/core/net-sysfs.c
@@ -527,27 +527,46 @@ void netdev_unregister_kobject(struct net_device * net)
        device_del(dev);
 }

+/* Add a sysfs group to the netdev groups */
+int netdev_sysfs_add_group(struct net_device *net,
+               const struct attribute_group *grp)
+{
+       struct attribute_group **groups = net->sysfs_groups;
+       struct attribute_group **end;
+
+       BUG_ON(net->reg_state >= NETREG_REGISTERED);
+       /* end pointer, with room for null terminator */
+       end = &net->sysfs_groups[ARRAY_SIZE(net->sysfs_groups) - 1];
+       for (; groups < end; ++groups) {
+               if (!*groups) {
+                       *groups = grp;
+                       return 0;
+               }
+       }
+       return -ENOSPC;
+}
+EXPORT_SYMBOL_GPL(netdev_sysfs_add_group);
+
 /* Create sysfs entries for network device. */
 int netdev_register_kobject(struct net_device *net)
 {
        struct device *dev = &(net->dev);
-       const struct attribute_group **groups = net->sysfs_groups;

        dev->class = &net_class;
        dev->platform_data = net;
-       dev->groups = groups;
+       dev->groups = net->sysfs_groups;

        dev_set_name(dev, "%s", net->name);

 #ifdef CONFIG_SYSFS
-       *groups++ = &netstat_group;
+       netdev_sysfs_add_group(net, &netstat_group);

 #ifdef CONFIG_WIRELESS_EXT_SYSFS
        if (net->ieee80211_ptr)
-               *groups++ = &wireless_group;
+               netdev_sysfs_add_group(net, &wireless_group);
 #ifdef CONFIG_WIRELESS_EXT
        else if (net->wireless_handlers)
-               *groups++ = &wireless_group;
+               netdev_sysfs_add_group(net, &wireless_group);
 #endif
 #endif
 #endif /* CONFIG_SYSFS */

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html