| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <20091119.121821.51205410.davem@davemloft.net>
Date: Thu, 19 Nov 2009 12:18:21 -0800 (PST)
From: David Miller <davem@...emloft.net>
To: peppe.cavallaro@...com
CC: netdev@...r.kernel.org
Subject: stmmac patches...
Please do not intermix coding style changes with bug
fixes.
In your second patch you change the indentation of
the arguments to ->init_rx_desc() in stmmac_suspend()
Not only is this inappropriate in a bug fix patch, it
is actually making the indentation incorrect. The
arguments should line up to the column after the
function argument set openning '(' on the previous
line.
Please fix this up and resubmit both of your patches.
Thank you.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists