[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <4B0719E6.4060402@gmail.com>
Date: Fri, 20 Nov 2009 23:36:22 +0100
From: Eric Dumazet <eric.dumazet@...il.com>
To: David Miller <davem@...emloft.net>
CC: therbert@...gle.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next-2.6] net: Xmit Packet Steering (XPS)
David Miller a écrit :
>
> I like this work. But as you know it still needs a little bit
> more work :-)
>
> Let's also pick a more decent name for the free function since
> tons of drivers are going to call this thing. How about
> dev_kfree_tx_skb()? :-)
>
> I see Jarek and you have come to a mutual understanding about the
> locking. Since you need to change it anyways to fix the deadlock,
> what using a netchannel like scheme to do remote SKB queueing?
>
> PAGE_SIZE queue arrays, lockless access to head and tail pointers, and
> if queue is full we local free.
>
> I think that's a reasonable policy and the only detail to work out is
> to make sure we never race on the IPI send and thus miss processing
> the queue.
>
> What do you think?
>
Thats good ideas David, I'll work on them next week, and do benchmarks as well
before sending a new version.
Thanks
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists