netdev - Re: [PATCH] ixgbe: move tc variable to CONFIG_IXGBE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 20 Nov 2009 06:24:21 -0800
From:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:	Jaswinder Singh Rajput <jaswinder@...nel.org>
Cc:	David Miller <davem@...emloft.net>, Yi Zou <yi.zou@...el.com>,
	Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@...el.com>,
	netdev <netdev@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ixgbe: move tc variable to CONFIG_IXGBE_DCB

On Fri, Nov 20, 2009 at 06:02, Jaswinder Singh Rajput
<jaswinder@...nel.org> wrote:
>
> tc is required by CONFIG_IXGBE_DCB.
> This also fixes compilation warning:
>
>  drivers/net/ixgbe/ixgbe_main.c: In function ‘ixgbe_tx_is_paused’:
>  drivers/net/ixgbe/ixgbe_main.c:245: warning: unused variable ‘tc’
>
> Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@...il.com>
> ---
>  drivers/net/ixgbe/ixgbe_main.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/ixgbe/ixgbe_main.c b/drivers/net/ixgbe/ixgbe_main.c
> index ebcec30..61a02ce 100644
> --- a/drivers/net/ixgbe/ixgbe_main.c
> +++ b/drivers/net/ixgbe/ixgbe_main.c
> @@ -242,11 +242,11 @@ static void ixgbe_unmap_and_free_tx_resource(struct ixgbe_adapter *adapter,
>  static inline bool ixgbe_tx_is_paused(struct ixgbe_adapter *adapter,
>                                       struct ixgbe_ring *tx_ring)
>  {
> -       int tc;
>        u32 txoff = IXGBE_TFCS_TXOFF;
>
>  #ifdef CONFIG_IXGBE_DCB
>        if (adapter->flags & IXGBE_FLAG_DCB_ENABLED) {
> +               int tc;
>                int reg_idx = tx_ring->reg_idx;
>                int dcb_i = adapter->ring_feature[RING_F_DCB].indices;
>
> --
> 1.6.5.3
>
>
> --

I just submitted a patch to fix this.  So NAK.

-- 
Cheers,
Jeff
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html